sui icon indicating copy to clipboard operation
sui copied to clipboard

[buck/sui-proxy] minimal buck setup to build sui-proxy

Open suiwombat opened this issue 9 months ago • 1 comments

Description

  • this PR contains the minimum viable BUCK dependency setup to build sui-proxy.
  • a majority of the changes are kept in two folders: buck/ and third-party/. There are a handful of BUCK files sprinkled around the sui repo which are passive unless acted on by the buck2 binary.
  • vendored sources are omitted to save repo space so there are details that need to be accounted for.
  • the BUCK files are not primary, cargo build still works and all associated tooling

There are some significant components here:

  • the buck2 prelude, these are "the rules/macros/etc" that make up builds, runs etc.
  • prelude-mysten, special prelude rules written for us and tooling
  • third-party, the third-party folder that reindeer controls. it handles git and crates.io deps

Most of the files are in the above. As previously mentioned, a few BUCK files are also found to support building sui-proxy.

I'm interested in landing this so that we can explore building sui-proxy and a few other tools using buck2 instead of cargo. All existing cargo tooling and workflows are remaining unchanged. All of the BUCK targets are codegen'd and can be rebuilt on demand.

Test Plan

buck2 build //crates/sui-proxy:sui-proxy-bin

You need to have a properly configured env to build this with buck. Ask Joe for details to help configure your environment.

asciicast

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

suiwombat avatar May 22 '24 01:05 suiwombat

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 10:33pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:33pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:33pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 10:33pm

vercel[bot] avatar May 22 '24 01:05 vercel[bot]