sui icon indicating copy to clipboard operation
sui copied to clipboard

[Traffic Control] Fully remove client IP param injection

Open williampsmith opened this issue 1 year ago • 1 comments

Description

This removes the plumbing to get client IP through json rpc requests by injecting into the request param.

Things NOT touched:

  1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything
  2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before.

Test plan

Existing tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

williampsmith avatar May 17 '24 18:05 williampsmith

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 3:58am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 18, 2024 3:58am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 18, 2024 3:58am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 18, 2024 3:58am

vercel[bot] avatar May 17 '24 18:05 vercel[bot]