CheckpointDiff, for displaying the concise difference between checkpoints in logs

[mystenmark]

For help in debugging checkpoint forks.

Unfortunately, it is of limited help with the current fork detection code, because the verified contents are unlikely to be available. Active fetching of remote contents can be added separately

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)			May 9, 2024 4:46pm
sui-kiosk	⬜️ Ignored (Inspect)			May 9, 2024 4:46pm
sui-typescript-docs	⬜️ Ignored (Inspect)			May 9, 2024 4:46pm

[github-actions[bot]]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[williampsmith]

We already have a case where we create checkpoint diffs for forks (and also check the remote contents for completeness), namely in the split brain diagnostics code: https://github.com/MystenLabs/sui/blob/e0a919d2ee8819d73e454b2d7f21240a763f1302/crates/sui-core/src/checkpoints/mod.rs#L2020

Given that your format seems cleaner, could we do the following here?

1. Make use of CheckpointDiff in the split brain code path above to replace the formatting I wrote
2. Factor out the remote contents fetching from the split brain code and use it here?

I can also do it in a separate PR if you wanna merge what you have. Just lmk

[github-actions[bot]]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.