sui icon indicating copy to clipboard operation
sui copied to clipboard

fix: Remove redundant dot in error message

Open howjmay opened this issue 9 months ago • 4 comments

Description

Like the following example error messages contains a redundant trailing dot.

Transaction execution failed due to issues with transaction inputs, please review the errors and try again: Gas budget: 1000 is lower than min: 1000000..

Test plan

Run ExecuteTransactionBlock with the update. Then the trailing dot will be removed

howjmay avatar Apr 26 '24 17:04 howjmay

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:32pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:32pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:32pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:32pm

vercel[bot] avatar Apr 26 '24 17:04 vercel[bot]

The change itself looks reasonable to me, but it looks like there are some tests (particularly, some snapshot tests) that also need to be updated -- would you mind updating those?

amnn avatar Apr 27 '24 22:04 amnn

Sure let me work on it

howjmay avatar Apr 28 '24 07:04 howjmay

It looks like there are still some more tests that need to be updated. See the output here for an example: https://github.com/MystenLabs/sui/actions/runs/8982457752/job/24675989734?pr=17362

amnn avatar May 07 '24 13:05 amnn

@howjmay is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 11 '24 23:05 vercel[bot]

Hi sorry for waiting. I was busy on sdk. I think I have fixed the errors!

howjmay avatar May 12 '24 06:05 howjmay

Almost -- you have one more test that needs updating. It's a little difficult to read the CI output in this case, so I have snipped out the relevant failure:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Differences ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: crates/sui/tests/snapshots/ptb_files_tests__move_call_fun_resolution.ptb.snap
Snapshot: move_call_fun_resolution.ptb
Source: crates/sui/tests/ptb_files_tests.rs:97
────────────────────────────────────────────────────────────────────────────────
Expression: results.join("\n")
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
   30    30 │    ╭─[4:13]
   31    31 │  3 │ --assign zero_x_zero @0x0
   32    32 │  4 │ --move-call zero_x_zero::option::is_none<u64> a
   33    33 │    ·             ─────┬─────
   34       │-   ·                  ╰── Object 0x0000000000000000000000000000000000000000000000000000000000000000 does not exist.
         34 │+   ·                  ╰── Object 0x0000000000000000000000000000000000000000000000000000000000000000 does not exist
   35    35 │  5 │ --move-call std::Option::is_none<u64> a
   36    36 │    ╰────
   37    37 │ 
   38    38 │   × Error when processing PTB
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.
test test_ptb_files::ptb_files/move_call/move_call_fun_resolution.ptb ... FAILED

failures:

---- test_ptb_files::ptb_files/move_call/move_call_fun_resolution.ptb ----
test panicked: snapshot assertion for 'move_call_fun_resolution.ptb' failed in line 97


failures:
    test_ptb_files::ptb_files/move_call/move_call_fun_resolution.ptb

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 38 filtered out; finished in 26.33s

amnn avatar May 13 '24 14:05 amnn

Sorry I didn't know that was the same error caused by this change. I have changed ptb_files_tests__move_call_fun_resolution.ptb.snap file

howjmay avatar May 13 '24 21:05 howjmay

Thank you for help too @amnn !

howjmay avatar May 14 '24 13:05 howjmay