sui icon indicating copy to clipboard operation
sui copied to clipboard

[zkLogin] Check that bigints fit into the field for extra safety

Open mskd12 opened this issue 1 year ago • 2 comments

Description

Turns out we don't check anywhere that the inputs fit into the field and neither does the poseidon-lite library (it just truncates elements and fits them into the field).

Instrumenting poseidon seems like the simplest way to do this. The other option (which I have not taken) is to instrument as soon as we receive some inputs..

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • [ ] protocol change
  • [ ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

mskd12 avatar Mar 26 '24 21:03 mskd12

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:39pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:39pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:39pm
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:39pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:39pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:39pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:39pm

vercel[bot] avatar Mar 26 '24 21:03 vercel[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 26 '24 01:05 github-actions[bot]