sui icon indicating copy to clipboard operation
sui copied to clipboard

Not display all consensus::tusk logs to the screen when running sui

Open lxfind opened this issue 3 years ago • 3 comments

Right now, when we launch sui, it will start to display all consensus::tusk logs even when there is no activity, and it's a lot. This makes it impossible to identify actual activities from the log. Can we not display information on every committed empty block from tusk?

lxfind avatar Apr 27 '22 17:04 lxfind

Should be alleviated by https://github.com/MystenLabs/narwhal/pull/181 but the original point stands.

huitseeker avatar Apr 27 '22 19:04 huitseeker

  • It's becoming better and better understood experimentally that the consensus signal from NW is valuable (e.g. to understand node health, the recovery process, etc) even if the block is empty,
  • our initial configs were misconfigured (max_header_delay = 100ms)
  • it's actually costly to introspect into the size of a block and decide if we should display it accordingly (comm across the primary-worker boundary)

=> I am tempted to close as Won't Fix. Any objections?

huitseeker avatar Jul 29 '22 22:07 huitseeker

no objections

asonnino avatar Jul 29 '22 22:07 asonnino