sui icon indicating copy to clipboard operation
sui copied to clipboard

[graphql] Update type name from `struct` to `datatype` in graphql API

Open tzakian opened this issue 1 year ago • 3 comments

Description

Updates the graphql API to use datatype instead of struct for non-primitive types. This will make transition when we add enums easier.

Test Plan

Make sure existing tests pass.

tzakian avatar Dec 20 '23 17:12 tzakian

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:50pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:50pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 5:50pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:50pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:50pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 5:50pm

vercel[bot] avatar Dec 20 '23 17:12 vercel[bot]

tiniest of nits but - dataType vs datatype?

Good question! I prefer datatype since that is used in other languages/would be consistent with other verbiage used in the enums work that I'm in the midst of, but if dataType for the GraphQL interface is preferable more than happy to change it.

tzakian avatar Dec 20 '23 17:12 tzakian

Updated to perform the additional renaming in OpenMoveType and push the renaming into the package resolver in the fixup commit.

tzakian avatar Dec 20 '23 19:12 tzakian