sui icon indicating copy to clipboard operation
sui copied to clipboard

[GraphQL/Package Resolver] Early check for type param arity mismatch

Open amnn opened this issue 2 years ago • 1 comments

Description

Move the test for type parameter arity mismatch into the first phase of layout calculation (while fetching packages). This helps avoid wasting work if we know the resolution will not succeed, and it also makes the likelihood of exceeding the type parameter width limit exceedingly low in practice, because all parameter widths are checked against the arity of a type that is actually loaded (so it would require the RPC's limit to be set lower than the limit on-chain).

Test Plan

This is a refactor of existing functionality so relies on existing tests:

sui-package-resolver$ cargo nextest run

Stack

  • #15393
  • #15407
  • #15408
  • #15409
  • #15410
  • #15442
  • #15443
  • #15444
  • #15445
  • #15446

amnn avatar Dec 20 '23 15:12 amnn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 0:59am
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 0:59am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 0:59am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 0:59am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 0:59am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 0:59am

vercel[bot] avatar Dec 20 '23 15:12 vercel[bot]