sui icon indicating copy to clipboard operation
sui copied to clipboard

[sui-transaction-builder] Remove dependency on sui-adapter

Open amnn opened this issue 1 year ago • 1 comments

Description

Remove logic in the transaction builder that relies on the execution layer, namely:

  • Type checking move call parameters, which other SDKs do not do, and is complicated by execution versioning.
  • Preventing calls to non-entry functions in Normal execution mode (which is not longer a restriction with the introduction of programmable transactions).

This removes the dependency on sui-adapter from sui-json and sui-sdk.

Test Plan

$ cargo simtest
$ env SUI_SKIP_SIMTESTS=1 cargo nextest run

Type of Change (Check all that apply)

  • [x] user-visible impact
  • [x] breaking change for a client SDKs
  • [x] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

  • unsafe_moveCall and unsafe_batchTransaction now ignore their execution_mode parameter, and always allow calls to non-entry programmable transactions.
  • Rust SDK no longer performs type resolution and checks (matching behaviour with TypeScript SDK).

amnn avatar Apr 20 '23 23:04 amnn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 1:44am
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 1:44am
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 1:44am
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 1:44am

vercel[bot] avatar Apr 20 '23 23:04 vercel[bot]