narwhal

narwhal copied to clipboard

Given that the majority of the spawned tasks on the codebase do not return a `JoinHandle` , I believe it would make sense to open a ticket and refactor them,...

huitseeker

Component restarts for our code bases

1

This is a sister issue of https://github.com/MystenLabs/fastnft/issues/382 (which is cross-repos)

huitseeker

Our customers want to integrate with Narwhal as a mempool first, which requires their consensus modules, co-located with a primary, to be able to query the mempool and update it...

huitseeker

[Bug, serialization] Check for the use of BTreeSet in internal messages

1

See https://github.com/zefchain/serde-reflection/tree/main/serde-reflection#security-caveat

huitseeker

RPC server for the Narwhal / external consensus API

4

### Epic See #44 and spec https://docs.google.com/document/d/1ogieB-Y-PkvINJLfpS9G5Tga4RrmBef3OO0RSHa1fyU/edit# ### Description We would like to stand up an RPC server over IPC to serve the Narwhal/consensus API. We have several endpoints to...

huitseeker

[automation] introduce a Makefile (or similar) for local tooling automation

5

Currently if someone needs to format the code, run the linter, bootstrap a node etc will need to do it manually. I believe if would have a Makefile (or some...

akichidis

trace properly (potential) byzantine peers

2

### Description On a few places in our codebase we check for the certificates validity. Some places are: * the [core](https://github.com/MystenLabs/narwhal/blob/4bbbd6e58bb86edcff570bbe03ad209bf72bfa58/primary/src/core.rs#L370) * the [block_synchronizer](https://github.com/MystenLabs/narwhal/blob/4bbbd6e58bb86edcff570bbe03ad209bf72bfa58/primary/src/block_synchronizer/responses.rs#L112) we should trace those occurancies via...

akichidis

Use common timeout across the block_waiter/block_remover paths

2

### Description We are using a few timeout configuration here and there already on multiple components when retrieving resources. Some examples: the `block_synchronizer` timeout configs: https://github.com/MystenLabs/narwhal/blob/fdd4f0b45b1d9bf499fb7822d8e1d36144b09fe6/config/src/lib.rs#L141 Similarly we do have...

akichidis

[network] Eliminate double serialization for the internal NW messages

1

https://github.com/MystenLabs/sui/pull/1844 We can do something similar for narwhal....except narwhal uses generic types which wont play nicely with the code gen which really wants concrete types. The crypto library needs to...

huitseeker

Refactor BlockRemover Component

3

There seems to be a lot of similarities with how `BlockRemover` & `BlockWaiter` operate and are used by `GetCollections` & `RemoveCollections`. Because of this there seems to be some items...

arun-koshy