narwhal icon indicating copy to clipboard operation
narwhal copied to clipboard

[crypto] accept references in batch verification

Open punwai opened this issue 3 years ago • 4 comments

Problem: In Narwhal crypto, we used to: Copy a Public Key every time we want to verify a signature (once from copying out of the 'committee' struct, the second time copying into the narwhal references function, which does not take in references)

This was probably fine with ed25519, where the public keys were already serialized bytes, but BLS12381 stores public keys in some other form - which adds extra cost very time we deep-copy the public keys. Note that this happened 30 times for each certificate.

punwai avatar Aug 01 '22 21:08 punwai

@punwai is this still something you want to go forward? If yes could you please the linter & tests as they seem to fail?

akichidis avatar Aug 04 '22 16:08 akichidis

@akichidis I think we'll definitely try to merge this, but after another PR goes through :)

punwai avatar Aug 04 '22 23:08 punwai

@huitseeker Added comments! Will ping again when this is rebased and refactored.

punwai avatar Aug 12 '22 19:08 punwai

@punwai What's the state of this one?

kchalkias avatar Aug 16 '22 15:08 kchalkias

Made obsolete by https://github.com/MystenLabs/fastcrypto/pull/90

huitseeker avatar Oct 11 '22 15:10 huitseeker