Prometheus metrics configuration should take a MultiAddr

Open huitseeker opened this issue 3 years ago • 1 comments

The Prometheus metrics are exposed on an endpoint that, unlike the rest of the infrastructure, is not specified with a Multiaddr but with a Socket, parsed from an IPV4 in its default instance: https://github.com/MystenLabs/narwhal/blob/28b2c89ded51f79386eed2e23c2a3325cfe3e8d6/config/src/lib.rs#L137-L150

It should be converted to use a Multiaddr like the rest of our config.

Jul 23 '22 15:07 huitseeker

FYI the conversation we had when introduced this https://github.com/MystenLabs/narwhal/pull/393#discussion_r910103634 . So I don't know if that's a bug, but rather a decision made. I agree let's bring everything in same format

Jul 25 '22 09:07 akichidis