fastcrypto icon indicating copy to clipboard operation
fastcrypto copied to clipboard

Modular crypto service

Open joyqvq opened this issue 3 years ago • 1 comments

joyqvq avatar Aug 30 '22 14:08 joyqvq

On a high level the tasks falls under:

  1. User Keystore
  • [x] Remove signer from AccountKeyStore https://github.com/MystenLabs/sui/pull/4828
  • [x] Use Keystore enum_dispatch instead of a boxed dynamic trait https://github.com/MystenLabs/sui/pull/4909
  • [x] Always invoke signing with Signature::new (there are few places we use try_sign, and this can be missed during migration) https://github.com/MystenLabs/sui/pull/5033
  • [x] Add intent signing under Signature::new_secure https://github.com/MystenLabs/sui/pull/3687
  • [ ] Switch Typescript sdk to Signature::new_secure
  • [ ] Switch Rust sdk to Signature::new_secure
  • [ ] Expose get_chain_id endpoint in API (wallet can store this and use when it signs)
  • [ ] Migrate sui-sdk crypto.rs and sui-types crypto.rs key related handling to a new crate sui-keys
  • [ ] Snapshot test for Sui client config https://github.com/MystenLabs/sui/issues/4977
  • [ ] Stretch goal: use AccountKeystore trait with Ledger's rust-sdk
  1. Validator Keystore
  • [ ] Switch AuthoritySignature AuthoritySignature::new_secure
  • [ ] TODO

cc @kchalkias @patrickkuo for some upcoming PR review contexts

joyqvq avatar Oct 04 '22 18:10 joyqvq