Kennet J
Kennet J
Mm, most of the issues are cause of copy-paste of existing stuff (except 3 and 4, which I didn't think about but that's reasonable). Anyway, I work on stuff related...
Do you think IsInputEnabled should check for visible too? Some places do that though not all, not sure if that's just left out by mistake more or less.
Hmm, probably not cause it does check in GetElementAt (which I believe is used in the input process to find the element to interact with?), but not 100% sure. Ed.:...
@eugeneko I would say that (0, 0) in that example is more correct (after all, if you do int(3 / 3.2f) the result is 0). What I am using the...
Are you sure there are any implicit calls with floats on IntVectors in the codebase? I tried setting the float operators to private, and it seems to compile without issue....
Well, I've no more things to add. My main point remains that by doing the conversion before the actual operations, the result is not the logically expected one. Who is...
@eugeneko I'm not trying to pick a fight with you you know. I am very well aware that it is not my decision how this goes forward, all I want...
Fair enough, but if one were to make it strict wouldn't it be best to disable those implicit conversions completely (by having them as private non-implemented methods)? Not everyone thinks...
Yes, that would work. I can get behind that. I guess we can wait a bit longer and see if anyone else has anything to add, and if not then...
I'm not sure static_assert will work for this, it seems to me like it always errors when done like this, even if the function isn't used.