myosuite icon indicating copy to clipboard operation
myosuite copied to clipboard

Quaternion difference in rotation reward

Open P-Schumacher opened this issue 10 months ago • 0 comments

It's not mathematically sound to directly substract quaternions as they follow their own algebra. This was used to compute a rotational reward here: https://github.com/MyoHub/myosuite/blob/4d146e1eec27b617111cb8c032107986849bf893/myosuite/envs/myo/myobase/walk_v0.py#L363

It should be replaced by a proper quaternion difference.

P-Schumacher avatar Apr 19 '24 20:04 P-Schumacher