skill-weather icon indicating copy to clipboard operation
skill-weather copied to clipboard

Changed words for rain and snow to another langauge and it still gives it to me in English

Open beemorris opened this issue 6 years ago • 8 comments
trafficstars

Hello! I am working on translating the weather skill to another language and I have changed the words for 'rain' to 'ruah' and 'snow' to 'vur' and MyCroft via text still gives me 'light snow' in English? I was expecting to get 'light vur'. I am including screenshots and I have changed the language in my mycroft.conf to the other language. Please let me know if there is anything else I need to do. Thank you!

screenshot from 2018-12-03 16-47-19 screenshot from 2018-12-03 16-47-45

beemorris avatar Dec 03 '18 21:12 beemorris

Hi there @beemorris, I'm Kathy - our Languages lead, firstly thanks for choosing Mycroft.

Firstly, are you able to show me the languages section of your mycroft.conf? The language codes used in different places are inconsistent (an action item I have to try and resolve).

We're also around in the Languages chatroom.

PS Is that Haka Chin language from Burma / Myanmar?

I can also add Haka Chin to https://translate.mycroft.ai if you wish to translate phrases there - then we can automatically update phrasing for all Skills for you.

KathyReid avatar Dec 04 '18 01:12 KathyReid

Hi not sure this will work but you might want to try with a light rain.dialog dialog file.

I've been looking at the logic briefly but I must do some more tests to see what's actually going on and what code is being used currently for the light modifier. If I don't get back soon remind me so I don't forget :)

forslund avatar Dec 04 '18 23:12 forslund

Hello @KathyReid , thank you for your reply and I'm sorry for my delayed response!

Here are the sections of my mycroft.conf file that contain language codes:

  // Code is a BCP-47 identifier (https://tools.ietf.org/html/bcp47), lowercased
  // TODO: save unmodified, lowercase upon demand
  "lang": "cnh-mm",
// Hotword configurations
  "hotwords": {
    "hey mycroft": {
        "module": "pocketsphinx",
        "phonemes": "HH EY . M AY K R AO F T",
        "threshold": 1e-90,
        "lang": "en-us"
        // Specify custom model via:
        // "local_model_file": "~/.mycroft/precise/models/something.pb"
        },

    "wake up": {
        "module": "pocketsphinx",
        "phonemes": "W EY K . AH P",
        "threshold": 1e-20,
        "lang": "en-us"
        }
  },
// Text to Speech parameters
  // Override: REMOTE
  "tts": {
    // Engine.  Options: "mimic", "google", "marytts", "fatts", "espeak", "spdsay", "responsive_voice"
    "module": "mimic",
    "mimic": {
      "voice": "ap"
    },
    "mimic2": {
      "lang": "en-us",
      "url": "https://mimic-api.mycroft.ai/synthesize?text="
    },
    "espeak": {
      "lang": "english-us",
      "voice": "m1"
    }
  },

Please let me know if there are any sections I missed or if you would like me to provide the whole file.

PS. Yes, it is Hakha Chin! =D And that would be great, thank you!

beemorris avatar Dec 05 '18 21:12 beemorris

Hello @forslund , I'll try that out, thank you! =D

beemorris avatar Dec 05 '18 21:12 beemorris

That language setting looks correct, thanks for providing it. I've added Hakha Chin to https://translate.mycroft.ai

https://translate.mycroft.ai/cnh-mm/mycroft-skills/

Kind regards, Kathy

KathyReid avatar Dec 06 '18 05:12 KathyReid

Hi everyone, I've had the same problem, but for German. In the weather skill the condition will be set to "rain and snow" from the weather report. After this the skill will try to translate the condition with its method self.__translate(...), but this will fail since there is no .dialog file called rain and snow.dialog. Just insert such file in dialog/<lang>/ with the right translation (for me Schneeregen ) and everything will be fixed. Cheers, Luca

lucacampanella avatar Nov 30 '20 16:11 lucacampanella

Hi Luca, thanks for the extra detail and highlighting that this still exists.

Unfortunately that dialog file will work for this one situation but won't for "light rain", "moderate rain", "light snow", etc...

There's some other pretty big fixes needed in this Skill so will try tackle it along with those.

krisgesling avatar Dec 09 '20 05:12 krisgesling

Major refactor to this skill was done recently. Is this still an issue?

chrisveilleux avatar Sep 21 '21 05:09 chrisveilleux