skill-weather icon indicating copy to clipboard operation
skill-weather copied to clipboard

Updated Italian translation

Open wave1972 opened this issue 3 years ago • 4 comments

Description

Italian translation had been left behind, many localization files expected by the updated skill were missing and they were causing Mycroft to break when a weather request was asked in Italian. This PR adds the missing files to the it-it folder, mirroring those in the English localization.

Type of PR

  • [x] Bugfix
  • [ ] Feature implementation
  • [ ] Refactor of code (without functional changes)
  • [ ] Documentation improvements
  • [ ] Test improvements

Testing

Documentation

No extra docs needed, this PR extends to Italian language changes already present in English.

wave1972 avatar Feb 18 '22 08:02 wave1972

Thanks Pynolo - I'll merge this in however wanted to warn you that if there are any different translations in translate.mycroft.ai they will overwrite these on the next sync. It's a one-directional sync so it currently has no idea whether translations in the Skill are technically newer or not.

krisgesling avatar Mar 03 '22 05:03 krisgesling

Hey @pynolo I just realised that the commit is from a different github account.

It might be some kind of error as it doesn't even look like a real account - any idea what's happened here?

krisgesling avatar Mar 03 '22 05:03 krisgesling

My bad, I did some of the work from my pc at work. I switched to temporary settings to hide my work git account but I forgot that placeholder account would show in the git commits. Sorry

---- On Thu, 03 Mar 2022 06:34:54 +0100 Kris Gesling @.***> wrote ----

Hey https://github.com/pynolo I just realised that the commit is from a different github account.

It might be some kind of error as it doesn't even look like a real account - any idea what's happened here?

— Reply to this email directly, https://github.com/MycroftAI/skill-weather/pull/200#issuecomment-1057683444, or https://github.com/notifications/unsubscribe-auth/ABIEY623HKQAAZTQQR72TM3U6BFP5ANCNFSM5OXHPQOA. Triage notifications on the go with GitHub Mobile for https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

wave1972 avatar Mar 03 '22 08:03 wave1972

Ah cool, I'll wait until it's fixed up and then we can merge it in.

krisgesling avatar Mar 04 '22 00:03 krisgesling