skill-weather
skill-weather copied to clipboard
Move dialog data translation to build location
Description
This updates the way the translation of data elements for dialog rendering is performed and should be considered a suggestion. It moves the translation to where the data is generated. By keeping translation close to the building it is easy to see which keys exists in the data reducing the risk of making mistakes.
It also makes the dialog more self-contained.
Resolves #189
Type of PR
- [ ] Bugfix
- [x] Feature implementation
- [ ] Refactor of code (without functional changes)
- [ ] Documentation improvements
- [ ] Test improvements
Testing
Ensure the correct responses for wind and temperature is generated
Documentation
Does documentation for this already exist? Are there docstrings on all the public methods you added or modified? Have these been updated?
CLA
To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement.
This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work. Additionally, it establishes that you retain the ownership of your contributed code and intellectual property. As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.
If you haven't already signed the agreement and been added to our public Contributors repo then please head to https://mycroft.ai/cla to initiate the signing process.