skill-weather
skill-weather copied to clipboard
Add missing weather icon codes
Description
Possible resolution of #187 Weather code mappings were missing 'night' versions of some conditions. This adds all codes listed in the OWM API docs and reorders the sets in numeric order
Type of PR
If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so: - [x]
- [x] Bugfix
- [ ] Feature implementation
- [x] Refactor of code (without functional changes)
- [ ] Documentation improvements
- [ ] Test improvements
Testing
Getting a forecast of rain after sunset should now produce an icon where previously no icon was returned.
Documentation
No changes to expected behavior
CLA
To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement.
This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work. Additionally, it establishes that you retain the ownership of your contributed code and intellectual property. As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.
If you haven't already signed the agreement and been added to our public Contributors repo then please head to https://mycroft.ai/cla to initiate the signing process.