skill-weather icon indicating copy to clipboard operation
skill-weather copied to clipboard

No translation of the temperature scales

Open putnik opened this issue 4 years ago • 2 comments

Describe the bug In weather messages, the temperature scale is not translated into the selected language.

To Reproduce Steps to reproduce the behavior:

  1. Change language to Russian
  2. Ask for current weather few times
  3. Wait for message with scale
  4. See untraslated scale (celsius/fahrenheit):
>> Сейчас небольшой дождь и 11 градусов celsius.
>> Сейчас дождь и 51 градусов fahrenheit.

Expected behavior Scales should be translated.

Environment:

  • Device type: Raspberry Pi
  • OS: Picroft
  • Mycroft-core version: dev

putnik avatar Nov 05 '21 13:11 putnik

Hey, thanks for flagging this. It certainly isn't the intention. I'm not sure when someone from our team will get to it so I've added a help wanted flag for now.

krisgesling avatar Nov 09 '21 02:11 krisgesling

This should be resolved by #197, I started out with a simple change to just translate the unit as other things are translated but in the end I ended up suggesting a slight reorganization to make the translations occur where the dialog is built to make it easier to avoid these kinds of issues in the future.

(It was tested with Swedish)

forslund avatar Jan 04 '22 13:01 forslund