Add sentiment-analysis

[TREE-Ind]

Info

This PR adds the new skill, sentiment-analysis, to the skills repo.

Description

Perform basic sentiment analysis

_{Created with mycroft-skills-kit v0.3.16}

[devops-mycroft]

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[krisgesling]

Hey Josh,

This is neat package! Interested to see where you take it.

It looks like MSK grabbed the wrong commit for the submodule. This is currently pointing to the commit: https://github.com/TREE-Ind/Sentiment-Analysis-Skill/tree/d14f4f292bc11456e517e32b2e66e14cb63378aa

Which I'm quite sure is not what you wanted :)

A few other suggestions:

1. The template settingsmeta.yaml is still in the Skill - this should get removed if you're not using any Skill settings.

2. We really need an automated test included so that we can verify that the Skill is not only working now, but so we can confirm that it continues to work as mycroft-core and other Skills change. The wallpaper tests from the new Homescreen Skill would be a good starting point here. The tests are here and the custom Step for "Then the wallpaper should be changed" is defined here. Basically it just detects whether the skill.homescreen.notify.wallpaper_changed message was emitted on the bus. Ping me if you need a hand with it

3. The Message you emit should be namespaced to your Skill so that we avoid clashes with some other future Skill doing something with sentiments. Eg skill.sentiment_analysis.sentiment

4. It looks like you have a duplicate method left in from testing - https://github.com/TREE-Ind/Sentiment-Analysis-Skill/blob/c2ba93678f651fb8185d37868c19b0a64f83377e/init.py#L15

5. It might be useful to include in the data object on your Message whether the sentiment relates to an utterance from the user, or dialog being spoken by the system.