mycroft-skills icon indicating copy to clipboard operation
mycroft-skills copied to clipboard

Add bringlist

Open AZAZ78 opened this issue 4 years ago • 11 comments

Info

This PR adds the new skill, bringlist, to the skills repo.

Description

It lets you add and remove items from your default shopping list and also clear all items.

Created with mycroft-skills-kit v0.3.16

AZAZ78 avatar Feb 14 '21 17:02 AZAZ78

Voight Kampff Integration Test Succeeded (Results)

devops-mycroft avatar Feb 14 '21 17:02 devops-mycroft

Hi there,

Thanks for submitting your first Skill! :tada:

To be included in the Marketplace the Skill goes through three reviews by our Skill Testing Team. You can read more about these reviews and the overall Skills Acceptance Process here: https://mycroft.ai/documentation/skills/skills-acceptance-process/

I took a very quick look and noticed that you have a configurable file that's expected to be in the Skills root directory. This is not guaranteed to be writeable by the Skill. Also if a user edits a file in that directory it will prevent it from updating as this would overwrite their changes.

I just added this page to our Skill docs showing the filesystem methods we have available for Skills including a specific namespaced directory that it's recommended Skills use for any writeable data files. https://mycroft-ai.gitbook.io/docs/skill-development/skill-structure/filesystem

If you have any updates to your Skill, you can update this pull request by running: mycroft-msk submit /opt/mycroft/skills/your-skill-dir

Also feel free to post here or in the Skills channel on Chat if you have any questions.

Looking forward to trying out your Skill :slightly_smiling_face:

krisgesling avatar Feb 15 '21 10:02 krisgesling

Hi Kris,

i will have a look on it at weekend. Nevertheless i took this pattern from some other already published skills, thought it is ok🤔

Best regards Alex

AZAZ78 avatar Feb 16 '21 18:02 AZAZ78

I changed the optional local credentials storage to the proposed persistent skill directory and used mycroft native functionality for this (also in the local credentials creator).

AZAZ78 avatar Feb 17 '21 10:02 AZAZ78

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Feb 17 '21 11:02 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Feb 17 '21 16:02 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Feb 19 '21 17:02 devops-mycroft

Voight Kampff Integration Test Succeeded (Results)

devops-mycroft avatar Feb 20 '21 16:02 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Feb 21 '21 10:02 devops-mycroft

Voight Kampff Integration Test Succeeded (Results)

devops-mycroft avatar May 15 '21 15:05 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Mar 22 '22 05:03 devops-mycroft