mycroft-skills icon indicating copy to clipboard operation
mycroft-skills copied to clipboard

Add jellyfin

Open tuxfoo opened this issue 4 years ago • 6 comments

Info

This PR adds the new skill, jellyfin, to the skills repo.

Description

Stream music from your Jellyfin server using Mycroft! Play all songs by an artist or an instant mix of any artist/album/song in your Jellyfin library.

Created with mycroft-skills-kit v0.3.16

tuxfoo avatar Oct 14 '20 16:10 tuxfoo

If some one at mycroft needs access to a jellyfin server to test this for approval then send me a PM and I will create a temp account and API key.

tuxfoo avatar Oct 14 '20 16:10 tuxfoo

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Oct 14 '20 16:10 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Oct 14 '20 20:10 devops-mycroft

Hey @tuxfoo,

I just took a quick glance and thought I'd throw a few tips out there. You may or may not be aware of them already

  • self.log.log(20, string) is the same as self.log.info(string)
  • If you don't need a method like initialize() it can be deleted from your Skill.

With the tests, I'm not sure why they are being executed by Voight Kampff when no VK tests are included. The tests in test/intent are in the format of the old integration test runner. @chrisveilleux can you shed some light on this?

krisgesling avatar Oct 16 '20 05:10 krisgesling

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Oct 17 '20 22:10 devops-mycroft

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Oct 18 '20 02:10 devops-mycroft