mycroft-skills-kit icon indicating copy to clipboard operation
mycroft-skills-kit copied to clipboard

Published 20 hours ago • verified publisher icon MycroftAI

Feature Request: Support SSH based remote url

Open krisgesling opened this issue 5 years ago • 2 comments

For developers using SSH keys with github, the remote url is in the form: [email protected]:krisgesling/deckchair-cinema-skill instead of the https standard: https://github.com/krisgesling/deckchair-cinema-skill.git

The MSK successfully submits and creates the PR, however the test runner fails as it "does not appear to be a git repository". See example test: https://jenkins.mycroft.team/job/19.02-skill-tester/133/console Currently, developers must change the remote url to the https format before submission.

Would it be worth testing for this format, and if found modifying this to the https standard during submission? Rather than handling multiple formats in MSM for example.

krisgesling avatar Apr 15 '19 07:04 krisgesling

I think this will not be a issue when shifting to use GitHub Personal Access Tokens in MSK as theese only works with https and not ssh.

andlo avatar Feb 09 '20 21:02 andlo

Just hit this again with this Skill submission: https://github.com/MycroftAI/mycroft-skills/pull/1473

krisgesling avatar Feb 04 '21 05:02 krisgesling