mycroft-precise icon indicating copy to clipboard operation
mycroft-precise copied to clipboard

Published 20 hours ago • verified publisher icon MycroftAI

Minor changes for compatibility to Python 3.10

Open icarosadero opened this issue 1 year ago • 3 comments

Made minor changes to allow this project to run on most recent versions of TensorFlow and Python 3.10

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • [x ] Bugfix
  • [ ] Feature implementation
  • [x ] Refactor of code (without functional changes)
  • [ ] Documentation improvements
  • [ ] Test improvements

Testing

How can someone reviewing this PR test that it is working properly? Is there appropriate test coverage for this change?

Documentation

Does documentation for this already exist? Are there docstrings on all the public methods you added or modified? Have these been updated?

CLA

To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement.

This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work. Additionally, it establishes that you retain the ownership of your contributed code and intellectual property. As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.

If you haven't already signed the agreement and been added to our public Contributors repo then please head to https://mycroft.ai/cla to initiate the signing process.

icarosadero avatar Jun 22 '23 16:06 icarosadero

Thank you! I hope someone is still around to merge this. Precise is a great project (and probably the only one that is open source and allow to train custom wake words)

Shulyaka avatar Aug 17 '23 23:08 Shulyaka

I also had to replace self.tf.GraphDef() with self.tf.compat.v1.GraphDef() on network_runner.py line 60 and self.tf.Session with self.tf.compat.v1.Session on line 56 of the same file.

Shulyaka avatar Aug 23 '23 21:08 Shulyaka

@icarosadero I've raised PR https://github.com/icarosadero/mycroft-precise/pull/1 Please accept it to apply my suggestions to this PR (is for like it).

Shulyaka avatar Aug 26 '23 19:08 Shulyaka