mycroft-precise icon indicating copy to clipboard operation
mycroft-precise copied to clipboard

Published 20 hours ago • verified publisher icon MycroftAI

Consolidate requirements

Open forslund opened this issue 4 years ago • 5 comments

This removes the requirements.txt and package list in setup.py in favor of the list in requirements/prod.txt and should resolve #172

It also bumps the numpy version to 1.16.2 to match the version listed in requirements.txt which should fix some errors with pyinstaller.

forslund avatar Aug 05 '20 09:08 forslund

Any reason this is hanging around for over a year?

jessecooper avatar Sep 29 '21 13:09 jessecooper

Maybe @MatthewScholefield or @krisgesling can review this?

NoamDev avatar Sep 29 '21 16:09 NoamDev

Hello,

Since I need that project, I decided to fork and advance. Sorry for the inconvenience but it can be reversed if Mycroft wants of course).

You will find your PR to the fork here.

Again, sorry for the inconvenient. I created a thread on Mycroft community forum to discuss if needed.

ShamoX avatar Jul 21 '22 01:07 ShamoX

Be careful, those changes generate a regression: wheel cannot build anymore, since setup.py needs requirements/prod.txt to be part of the package and is not.

I revert the change and propose to remove entirely requirements/prod.txt and use correctly setup.py list: https://gitlab.com/liant-sasu/mycroft-precise/-/merge_requests/13

ShamoX avatar Jul 24 '22 04:07 ShamoX

@ShamoX https://github.com/jessecooper/mycroft-precise/tree/dev/requirements This is what I am currently running with.

jessecooper avatar Jul 26 '22 16:07 jessecooper