mycroft-core icon indicating copy to clipboard operation
mycroft-core copied to clipboard

Mycroft-config: Fix deprecated --tempfile in nano

Open Tony763 opened this issue 3 years ago • 2 comments

Description

As described in Issue #3124, --tempfile was deprecated in Nano version 5.0.

Switching to --saveonexit would break function on older versions (Ubuntu 20.04 LTS use 4.8 version).

Thankfully, the short version of those two is still the same -t. Using it will preserve function on older systems and fix function on newer ones.

How to test

Try to edit config.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

Tony763 avatar Oct 26 '22 18:10 Tony763

Codecov Report

Base: 54.05% // Head: 54.04% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (d1b9fa2) compared to base (48dd100). Patch has no changes to coverable lines.

:exclamation: Current head d1b9fa2 differs from pull request most recent head c4ac8ba. Consider uploading reports for the commit c4ac8ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3140      +/-   ##
==========================================
- Coverage   54.05%   54.04%   -0.01%     
==========================================
  Files         120      120              
  Lines       11032    11032              
==========================================
- Hits         5963     5962       -1     
- Misses       5069     5070       +1     
Impacted Files Coverage Δ
mycroft/client/speech/listener.py 48.04% <0.00%> (-0.36%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 26 '22 18:10 codecov-commenter

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft avatar Oct 26 '22 19:10 devops-mycroft