mycroft-core icon indicating copy to clipboard operation
mycroft-core copied to clipboard

Upgrade PIP to 21.3.1

Open krisgesling opened this issue 3 years ago • 5 comments

Description

Upgrade PIP to latest version.

There have been an extensive number of bugfixes, improvements and deprecations. Nothing that I've seen that should really impact us.

@forslund I remember hearing about issues with a previous PIP update - are there specific things you can remember that we should be on the lookout for?

Tested on:

  • [x] Ubuntu 20.04 VM
  • [x] Upgrading pip on an existing Mark II
  • [x] Build of new Mark II image
  • [ ] Upgrading pip on an existing Mark 1

Contributor license agreement signed?

  • [x] CLA

krisgesling avatar Jun 23 '21 05:06 krisgesling

Codecov Report

Merging #2923 (8f5d9b1) into dev (7a9c762) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 8f5d9b1 differs from pull request most recent head 2c0429e. Consider uploading reports for the commit 2c0429e to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2923   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files         123      123           
  Lines       11016    11016           
=======================================
  Hits         5797     5797           
  Misses       5219     5219           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a9c762...2c0429e. Read the comment docs.

codecov-commenter avatar Jun 23 '21 05:06 codecov-commenter

Voight Kampff Integration Test Succeeded (Results)

devops-mycroft avatar Jun 23 '21 06:06 devops-mycroft

As long as the dev-setup.sh works as intended (delete .venv and do a fresh install of everything) it's ok. It's usually the .0 versions that has caused some regressions when installing some packages.

forslund avatar Jun 23 '21 07:06 forslund

Thank you I can't remember the exact cause but there was one instance when I upgraded to pip 21.1.2 from /usr/local/lib/python3.8/site-packages/pip (python 3.8) when it first was available and it did a trace back, so I downgraded so as to complete what I was doing, usually I make detailed notes but I was in a rush at the time. I have I have since upgraded back to latest version and all seams well.

I am doing all of my development on openSUSE Tumbleweed with 5.12.12 kernel with KDE 5.22.x and is kept up to date with the latest updates once each day, despite all the updates an incredibly rock solid machine. Then when I want to test I move it to my Pi 4/4G with a 250GB drive. I do it this way as the 8CPU Xeon has all the horse power to do anything quickly.

While on this note, as python 3.10 is coming in October, I was curios if there had been any trials with python 3.9?

On 2021-06-23 1:46 a.m., Kris Gesling wrote:

Description

Upgrade PIP to latest version.

There have been an extensive number of bugfixes, improvements and deprecations. Nothing that I've seen that should really impact us.

@forslund https://github.com/forslund I remember hearing about issues with a previous PIP update - are there specific things you can remember that we should be on the lookout for?

Tested on:
  • Ubuntu 20.04 VM

  • Upgrading pip on an existing Mark II

  • Build of new Mark II image

  • Upgrading pip on an existing Mark 1

    Contributor license agreement signed?

  • CLA


    You can view, comment on, or merge this pull request online at:

https://github.com/MycroftAI/mycroft-core/pull/2923 https://github.com/MycroftAI/mycroft-core/pull/2923

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MycroftAI/mycroft-core/pull/2923, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALY7LCYNWORVZMDHCEW4VJDTUFYLHANCNFSM47FB2EFQ.

-- Valentine Stubbs Chief Operations Officer Development, Operations & Custom Systems Integrations 301-2076 Sherobee Road Mississauga, Ontario L5A 4C4

vvstubbs avatar Jun 23 '21 15:06 vvstubbs

Great, I'm going to push the change to the Mark II latest build for a few days just to be extra sure.

@vvstubbs thanks for reporting your experience too. In terms of Python3.9 there are a few issues we've seen at least with training the Padatious intents. So I wouldn't be using it in any production environment just yet.

krisgesling avatar Jun 24 '21 04:06 krisgesling