mycroft-core
mycroft-core copied to clipboard
MycroftAI
Read skills from XDG Base directory specification locations
Description
~This makes mycroft-core read skills from all locations as specified by the XDG Base Directory specification, so in /usr/share/mycroft/skills, /usr/local/share/mycroft/skills, and $XDG_DATA_HOME/.local/share/mycroft/skills if it exists and otherwise ~/.local/share/mycroft/skills.~
This makes mycroft-core read skills from the XDG Base Directory location in the user's home folder, so $XDG_DATA_HOME/.local/share/mycroft/skills if it exists and otherwise ~/.local/share/mycroft/skills.
This requires https://github.com/MycroftAI/mycroft-skills-manager/pull/90 for the installation of skills part.
How to test
- Apply https://github.com/MycroftAI/mycroft-skills-manager/pull/90 to msm
- Install some skills
- Start Mycroft and check if skills in the required directories are being loaded properly
Contributor license agreement signed?
CLA [x]
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Hello @PureTryOut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2022-06-02 05:58:07 UTC
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Was just glancing at this as we were looking at the PR for MSM and I wondered if we also need to update scripts/prepare-msm.sh which seems to also have the /opt/mycroft/skills path hardcoded
I wondered if we also need to update
scripts/prepare-msm.shwhich seems to also have the/opt/mycroft/skillspath hardcoded
Good call, yes it needs to be. Fixed.
EDIT: Actually never mind, this script isn't needed at all anymore. The new skill directories don't require root rights and will be made by the pyxdg dep if they don't exist yet, so no need preparing anything. I'll just remove the script.
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log
I have tested this as part of #2799 and works perfectly and as expected.
- Skills are downloaded to /home/
/.local/share/mycroft/skills/ - Skills repo is initiated within /home/
/.local/share/mycroft/skills-repo (no more hidden directory)
The only little quirck I had was that at a very virgin system where the user does not yet have a "site-packages" within his/her ~/.local/share/lib/ folder, starting mycroft; At the start of Python as the users site-packages are not there yet, it will not be loaded. packages will be installed to it with pip, however mycroft will not see them before a restart as that folder was not initialized at its start. (If this makes any sense) Anyhow, I believe this is more a MSM thing then mycroft-core.
Anyhow: In short. Works as expected!
Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log