mycroft-core
mycroft-core copied to clipboard
MycroftAI
additional lang folders
aditional language
Description
This tryes to add additional language folder as described in #2509
Additional lanuage folders are placed for each skill under ~/.mycroft/translations
Added settings for this in mycroft.cong under general skillsettings
// General skill values
"skills": {
"translations_dir": "~/.mycroft/translations",
// prefear translations over skills own translation
"prefere_translations": false
}
Added so the additional language folder is read when adding rescource files
It also add the additional language folder to the watching for changes in skill_loader so canges and addings to files at that place will reload the skill.
How to test
- Use other language than en-us
- move files from hellow-world-skill (all files in other lang) from cocab and dialog older to ~/.mycroft/translations/mycroft-hello-world.mycroftai/
- (so all resource files in same folder! - See that mycroft picksup resource files from new place.
- make change in one file and se that he reloads skil and picksup changes
Contributor license agreement signed?
CLA [ X] (Whether you have signed a CLA - Contributor Licensing Agreement
I cant figure out why test fails. It seems to be that I use od.path.expanduser() but that is called with the string from the mycroft setting. So it shouldnt be NoneType.
Great and thanks. I will redo my work and keep the funcions and see if I can figure out what jenkins says....
@HKalbasi see the Roadmap link in the status change above. I haven't gotten used to checking that, but it's cool.
Anyway, this was moved to "Longer term," which is described as
Work that is needed but can wait until “Next” [category to the right] items are finished
Hi all, please reconsider this to be not that much longer term. This would be extremely useful especially for non en-en users.
Hey, I can't give you a date when the internal team will start work on it, but better multi-lingual support is one of our top 5 priorities. So it is going to get a lot of attention this year. Personally I think something like this PR is the way to go too.
Hey @krisgesling now that the new Mark II is out, what is the status of this?