mimic1 icon indicating copy to clipboard operation
mimic1 copied to clipboard

Check for libpulse-simple.pc

Open mgorse opened this issue 7 years ago • 3 comments

I needed this change in order to get mimic to build. (I have version 11.0 installed, but pulseaudio-simple.pc has existed since at least version 0.9.12, so this change looks safe to me.)

mgorse avatar Oct 06 '17 05:10 mgorse

Codecov Report

:exclamation: No coverage uploaded for pull request base (development@9dfaa6b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #138   +/-   ##
==============================================
  Coverage               ?   40.71%           
==============================================
  Files                  ?       78           
  Lines                  ?     9031           
  Branches               ?     1558           
==============================================
  Hits                   ?     3677           
  Misses                 ?     5354           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dfaa6b...16c0d5e. Read the comment docs.

codecov-io avatar Oct 06 '17 05:10 codecov-io

Sorry; just realized that I pushed this with an invalid email address. Should I submit a new pull request with a correct address?

mgorse avatar Oct 06 '17 05:10 mgorse

Thanks @mgorse I can reproduce the error. We are in the process of splitting mimic in several components. This fix would need to be applied to the mimic-core component at these two lines:

  • https://github.com/MycroftAI/mimic-core/blob/development/meson.build#L137
  • https://github.com/MycroftAI/mimic-core/blob/development/meson.build#L143

I will be happy to merge a pull request to that repository if you want to create it (preferably with a valid email address). Otherwise, just tell me here and I will do the commit myself.

Thanks for the report

zeehio avatar Oct 06 '17 21:10 zeehio