lingua-franca icon indicating copy to clipboard operation
lingua-franca copied to clipboard

Published 20 hours ago • verified publisher icon MycroftAI

feature/pronounce_digits

Open ChanceNCounter opened this issue 4 years ago • 3 comments

ChanceNCounter avatar Nov 03 '20 18:11 ChanceNCounter

add unittests and this should be good, i'm not sure about the behaviour for all_digits=False, i bet there is some language where we will run into an issue like catalan having 4 ways to pronounce time....

JarbasAl avatar Dec 16 '20 00:12 JarbasAl

I expect the variant decorator will be able to deal with that, if and when the time comes. I'm still getting my arms all the way around it, but it seems like you covered all the bases.

ChanceNCounter avatar Dec 16 '20 03:12 ChanceNCounter

@krisgesling This obviously needs a rebase, but the code itself is merged and working at Chatterbox, so I think it's good to go if you agree. Just need to get around to the rebase.

ChanceNCounter avatar Jun 04 '21 21:06 ChanceNCounter