MyPet icon indicating copy to clipboard operation
MyPet copied to clipboard

Give pets water breathing if the player has the conduit effect

Open Mac15001900 opened this issue 4 years ago • 3 comments

Feature request

What part of MyPet needs this?

  • [X] the plugin itself
  • [ ] the Skilltree Creator
  • [ ] the website

Is your feature request related to a problem? Please describe

When living in an underwater base, it's somewhat annoying to have to keep sending your pet away every time you go outside and then call it when you go back inside - but otherwise it will likely die of suffocation underwater.

Describe the solution you'd like

When the player has the conduit effect, the pet should get the water breathing effect of equal duration, similarly to how they mimic potion effects.

Describe alternatives you've considered

Anything that will stop pets from dying underwater will do, but requiring a conduit seems like a balanced way to do it.

Additionally, it'd be nice if in this situation the pet would try to get its y position equal to players instead of swimming upwards, if this is somehow possible.

Additional context

Add any other context or screenshots about the feature request here.

Bukkit/Spigot/Bungee Build/Version and MyPet Build/Version:

Unknown; playing on a public server where this info is not available (other than it being Spiggot). From browsing the changelog it doesn't seem like this feature was ever added, so the problem will likely occur in newer versions too.

Mac15001900 avatar May 17 '20 16:05 Mac15001900

Pets function off the Vanilla Wolf AI. This is why they always "Swim Up", and because of this there is no reason for any sort of "water breathing" to be applied as the pets aren't meant to "swim" to begin with. Just as the Vanilla Wolves and Cats don't swim with the player either.

zerafox avatar May 17 '20 17:05 zerafox

Maybe I should clarify what the main problem is: it's having to type a command every time I walk through a door of my base. The pet swimming up is rarely the solution, since if the player keeps moving, the pet will keep teleporting back down, and will likely never reach to the surface and drown. Mimicking the conduit effect, similarly to how pets (unlike vanilla wolfs) become invisible when the player drinks an invisibility potion, would solve this problem.

Mac15001900 avatar May 17 '20 18:05 Mac15001900

So would dismissing the pet before going diving.

zerafox avatar May 17 '20 19:05 zerafox