emogrifier icon indicating copy to clipboard operation
emogrifier copied to clipboard

Use dedicated classes instead of arrays with special keys

Open oliverklee opened this issue 5 years ago • 1 comments

This will make the code more explicit and help static code analysis.

Particularly, we should get rid of compact, list and family.

oliverklee avatar Sep 29 '19 09:09 oliverklee

it appears that CssConcatenator::getOrCreateMediaRuleToAppendTo() may require a dedicated class in order to satisfy some MixedPropertyFetch issues in psalm: https://github.com/MyIntervals/emogrifier/blob/6f9d875f0054ab3d8cd6a972a7d517ced19a2040/src/Utilities/CssConcatenator.php#L103

SignpostMarv avatar Oct 06 '19 12:10 SignpostMarv