PHP-CSS-Parser icon indicating copy to clipboard operation
PHP-CSS-Parser copied to clipboard

Published 20 hours ago • verified publisher icon MyIntervals

CSS comments lead to exception

Open oliverklee opened this issue 1 year ago • 2 comments

https://github.com/MyIntervals/emogrifier/actions/runs/10573250071/job/29292403949?pr=1248

1) Pelago\Emogrifer\Tests\Unit\CssInlinerTest::inlineCssFiltersUnneededCssThings with data set "CSS comments with one asterisk" ('p {color: #000;/* black */}', 'black')
Sabberworm\CSS\Parsing\UnexpectedTokenException: Identifier expected. Got “}” [line no: 1]

/home/runner/work/emogrifier/emogrifier/vendor/sabberworm/php-css-parser/src/Parsing/ParserState.php:143

We need to cover this with a test and fix it in main and for v8.x

@ziegenberg Would you be willing to have a look at this?

oliverklee avatar Aug 27 '24 07:08 oliverklee

Yes, I'll have a look. Maybe tomorrow but probably next week.

ziegenberg avatar Aug 27 '24 08:08 ziegenberg

Thanks! :heart:

oliverklee avatar Aug 27 '24 08:08 oliverklee