PHP-CSS-Parser icon indicating copy to clipboard operation
PHP-CSS-Parser copied to clipboard

Minimum version of `composer-normalize` requires PHP 7.4

Open JakeQZ opened this issue 11 months ago • 2 comments

This is a PHIVE-installed pacakage.

We could do one of two things:

  • Reduce the minimum version requirement in phars.xml to allow a version compatible with PHP 7.2;
  • Document in the contribution guidlines that whilst PHP 7.2 and 7.3 can be used to run the unit tests against those versions, they can't be used for the full suite of CI checks.

JakeQZ avatar Mar 25 '25 00:03 JakeQZ

Reduce the minimum version requirement in phars.xml to allow a version compatible with PHP 7.2;

This in general is difficult as this would require the corresponding tool to support the full range of PHP versions that we support.

Document in the contribution guidlines that whilst PHP 7.2 and 7.3 can be used to run the unit tests against those versions, they can't be used for the full suite of CI checks.

Either this, or we move it to Composer and use a multi-version dependency (like we already are doing with PHPStan).

In any case, the results of static code analysis might vary depending on the version of PHP that is used to run the tests (even though it would be possible to at least execute the checks). So we need to document this anyway.

I tend to a "move it to Composer and document the caveats" (and also move the other tools to Composer so we can get rid of PHIVE). What do you think?

oliverklee avatar Mar 25 '25 09:03 oliverklee

In any case, the results of static code analysis might vary depending on the version of PHP that is used to run the tests (even though it would be possible to at least execute the checks). So we need to document this anyway.

Yes, I found switching to PHP 7.3 required a downgrade of PHPStan from 2.1.2 to 1.12.16, resulting in two additional errors reported, and many other errors not reported.

JakeQZ avatar Mar 25 '25 16:03 JakeQZ