PHP-CSS-Parser icon indicating copy to clipboard operation
PHP-CSS-Parser copied to clipboard

Rename `Rule.rule` to `Rule.propertyName`

Open oliverklee opened this issue 1 year ago • 2 comments

As suggested in a review: https://github.com/MyIntervals/PHP-CSS-Parser/pull/1004#discussion_r1972654857

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration

oliverklee avatar Feb 27 '25 08:02 oliverklee

It's already private, so we can do this without any deprecation issues.

JakeQZ avatar Feb 27 '25 09:02 JakeQZ

OTOH, there are the getRule and setRule methods, which would need corresponding getPropertyName and setPropertyName replacements, and a deprecation notice for the originals saying to use the replacements.

JakeQZ avatar Feb 27 '25 09:02 JakeQZ