etherwallet
etherwallet copied to clipboard
MyEtherWallet extension for Firefox
First of all—I will dash out a few issues today, but please know that it's not insatiability from my end. I thank you very much for the amazing product you brought about!
I'm wondering if you're planning porting MyEtherWallet CX to Firefox. Google's browser is avoided by many for suspicion of its security and this is amplified when it comes to cryptocurrency. The dist release runs well in Firefox, but lacks a number of features compared to CX. And opening the CX's files in Firefox doesn't produce an operational interface.
Into the backlog too. I'm just killing you today.
I just heard that jaxx is discontinuing their FF extension. Any insights into why?
They don't tell either. https://decentral.zendesk.com/hc/en-us/articles/115000276854 On twitter, they said something like they have problems with Firefox addons.
It is interesting that they decided to do so after the public realized their wallet security is extremely low and the implementation is even worse. And they handled this with saying "not our problem, don't use it for big amounts". In fact I'd rather they discontinue all their products.
The good news is Firefox add-on now support almost the same API of chrome extension, I follow the doc and ran their web-ext tool and MyEtherWallet extension icon can show correctly on FirefoxNightly.
cd etherwallet/chrome-extension
web-ext run --firefox=nightly
Though to ship onto Firefox addon, there are some lint issues need to be solved from MyEtherWallet side.
Here's the web-ext lint
result
$ web-ext lint
Validation Summary:
errors 2
notices 1
warnings 17
Error:
-
jquery-1.12.3.min.js
is too old and unsafe, need update. more details https://bit.ly/1TRIyZY -
etherwallet-master.js
is larger than 4mb, which will not be parsed
Warnings:
- avoid assign innerHTML if possible
- Firefox addons runs in strict mode which does not allow inline JS. (helpers.html, cx-wallet.html contain inline JS)
Those lint warnings are not specific to firefox, so fixing those seems also improve chrome extension's quality
jQuery is only used for paper wallet and should be converted and removed.
In v4 we inline the paper wallet on HTML page to eliminate problem and remove elements you don't want to print via css
For too large, we need to test uglified v again (last time it broke some things) or see if there are unused things we can remove. Contract abis come to mind. Probably some libs. The translations are way smaller in 3.10 so that alone by?
Maybe** (I hate GitHub moble)
Just looked into this a bit as I am interested in using it with ffx.
Current state: Errors:
- jquery - what should it be converted to?
- you mentioned 3.10 maybe being smaller, as observed from Github it actually got bigger with etherwallet-master.js going from 4.66 to 5.03 MB (more or less)
Warnings:
- says that custom csp needs additional review/more time
- but in return, innerhtml/inline script are then allowed by this csp afaik
Would be great if I can do somethign to help with this vor v4 if necessary, but I do not want to randomly remove stuff to make etherwallet-master.js smaller if that is the main thing stopping this.
Is there any update?