etherwallet icon indicating copy to clipboard operation
etherwallet copied to clipboard

add VIC nodes.js

Open Victorium-org opened this issue 7 years ago • 8 comments

Victorium-org avatar Oct 24 '18 22:10 Victorium-org

@Victorium-org Is there any reason why your chainID doesn't match what the net_version return?

gamalielhere avatar Oct 29 '18 21:10 gamalielhere

Protocol Versions: [63 62], Network Id: 93610431, Chain Id: 4388577777

Victorium-org avatar Oct 29 '18 21:10 Victorium-org

@Victorium-org okay cool. Do you mind syncing your branch to the mercury branch? The ci test need to pass before I can merge it.

gamalielhere avatar Oct 29 '18 21:10 gamalielhere

what i need to do now ?

Victorium-org avatar Oct 30 '18 23:10 Victorium-org

@Victorium-org merge our current mercury branch with your local one so it's in sync. That should fix the CI error.

gamalielhere avatar Nov 01 '18 02:11 gamalielhere

chainId 4388577777 : https://github.com/VictoriumProject/go-victorium/blob/master/core/config/mainnet.json#L40

no bip44 entry found for victorium.

travis error: Cannot find module './abiDefinitions/vicAbi.json'

and currently, not a working node.

curl --header Content-Type: application/json -X POST --data {"jsonrpc":"2.0","method":"net_version","params":[],"id":1} https://node.victorium.org:8555
curl: (7) Failed to connect to node.victorium.org port 8555: Connection refused

hackmod avatar Nov 11 '18 04:11 hackmod

@gamalielhere I don't think this should be merged without SLIP44 registration. I'd recommend to remove your approval from the PR.

mkrufky avatar Nov 13 '18 23:11 mkrufky

@mkrufky thanks for the heads up, unfortunately, I don't think I can remove my approval. I'll hold off on merging this until it gets added to bip44 and if the node is back up.

gamalielhere avatar Nov 14 '18 00:11 gamalielhere