chainId in nodes.js x888 currency is changed to 0

[svetanto]

for Evgeny Odnolko

[ghost]

@svetanto Did you checked that your chainid works on your network?

[svetanto]

Yes.

2018-06-01 16:48 GMT+03:00 Akira Takizawa [email protected]:

@svetanto https://github.com/svetanto Did you checked that your chainid works on your network?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kvhnuke/etherwallet/pull/1882#issuecomment-393886031, or mute the thread https://github.com/notifications/unsubscribe-auth/AZ-1XHu4OdPIEjC4S4OBBPCk3CvsbZ5Gks5t4UYhgaJpZM4UWXwZ .

[hackmod]

where can i find x888 public git repo?

[svetanto]

Eightereum network has not repositories since it formed from unmodified geth clients with nginx load balancing. Geth git (go-ethereum) you can find at corresponded github pages.

2018-06-02 6:55 GMT+03:00 HackyMiner [email protected]:

where can i find x888 public git repo?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kvhnuke/etherwallet/pull/1882#issuecomment-394055797, or mute the thread https://github.com/notifications/unsubscribe-auth/AZ-1XLy08lMkt0620IpbxR_Joqp6B2Xkks5t4gy8gaJpZM4UWXwZ .

[fxsecltd]

Correct working was checked via adding custom node with parameters, equal to x888 node parameters, except chainid (if chainid is 0, all requests have success responces, if chainid is 888 - write requests have 'invalid sender' responses).

[fxsecltd]

Why this request still not merged, maybe it has some issues? New release already gone, but pull request still not merged.

[hackmod]

you can't set chainid as 0. Please see https://github.com/ethereum/go-ethereum/issues/13847