MyCrypto
MyCrypto copied to clipboard
Tx Receipt Type Changes
Description
Makes changes to txReceipt types and make tx history panel and tx status panels more useful.
Changes
- Added a token transfers section to txStatus.
- Added sent/received asset(s) fields in tx history panel.
- Changed up
ITxReceipt
types to handle valueTransfers (so we can display more than one asset transfer in txhistory and txstatus panels at a time). - Added a displayAsset field to redux state txs to better handle displays
- Changed up txType derivations to better handle naming/labels/icons.
- Added unknown erc721 and base asset value transfers (base is used for internal transactions when receiving eth from exchange txTypes).
- Unified
mtime
s to be1234567891011
in fixtures, so it's easier to test against them.
Staging build: MyCryptoBuilds
Codecov Report
Merging #4238 (d39b674) into master (144b8aa) will increase coverage by
0.66%
. The diff coverage is97.92%
.
@@ Coverage Diff @@
## master #4238 +/- ##
==========================================
+ Coverage 78.73% 79.40% +0.66%
==========================================
Files 572 575 +3
Lines 12429 12593 +164
Branches 3068 3149 +81
==========================================
+ Hits 9786 9999 +213
+ Misses 2611 2564 -47
+ Partials 32 30 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/components/Account.tsx | 86.36% <ø> (ø) |
|
...omponents/SignTransactionWallets/WalletConnect.tsx | 84.09% <ø> (ø) |
|
src/components/Table.tsx | 83.87% <ø> (ø) |
|
src/components/TransactionFlow/TxPendingState.tsx | 100.00% <ø> (ø) |
|
...s/TransactionFlow/displays/FaucetReceiptBanner.tsx | 100.00% <ø> (ø) |
|
...tectTransaction/components/ProtectTxProtection.tsx | 46.15% <ø> (ø) |
|
src/features/SwapAssets/components/SwapQuote.tsx | 66.66% <ø> (ø) |
|
src/features/Dashboard/components/helpers.ts | 88.88% <90.00%> (+62.80%) |
:arrow_up: |
...ts/TransactionFlow/displays/TokenTransferTable.tsx | 90.90% <90.90%> (ø) |
|
src/components/TransactionFlow/TxReceipt.tsx | 86.80% <96.87%> (+0.19%) |
:arrow_up: |
... and 29 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 144b8aa...d39b674. Read the comment docs.
Can you please rebase to master, since #4276 was merged?