MyCrypto
MyCrypto copied to clipboard
Fix RSK EIP1191 checksum issues
Description
I created new PR according to requesting changes in #4139
Changes
- Renamed
isValidETHRecipientAddress
withisValidRecipientAddress
which now takes chainId parameter. - Removed unnecessary network state and updated schema validation.
- Added
network
parameter toTO_FIELD_ERROR
translation. - Reverted changes in
providerHandler
to find a better solution.
This changes are supposed to fix checksum errors in the following scenarios:
- Send Asset through RSK and RSK Testnet networks and
- In Settings add RSK and RSK Testnet addresses to Address Book
Issues
There are more scenarios where EIP1191 checksum validation needs to be fixed.
- Interact with Contracts
- Add Custom Token
We discussed for the better solution as to have support for it in Ethers.js.
/ok-to-test
Codecov Report
Merging #4151 (2a0fed9) into master (56f7210) will decrease coverage by
0.01%
. The diff coverage is78.57%
.
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
- Coverage 77.43% 77.42% -0.02%
==========================================
Files 551 551
Lines 12016 12018 +2
Branches 3197 3197
==========================================
Hits 9305 9305
- Misses 2678 2680 +2
Partials 33 33
Impacted Files | Coverage Δ | |
---|---|---|
...ures/InteractWithContracts/components/Interact.tsx | 69.00% <ø> (ø) |
|
.../features/Settings/components/AddToAddressBook.tsx | 15.15% <0.00%> (-0.98%) |
:arrow_down: |
src/components/GeneralLookupField.tsx | 89.01% <100.00%> (ø) |
|
.../features/SendAssets/components/SendAssetsForm.tsx | 77.17% <100.00%> (+0.09%) |
:arrow_up: |
src/services/EthService/validators.ts | 95.93% <100.00%> (+0.12%) |
:arrow_up: |
src/features/Faucet/helpers.tsx | 100.00% <0.00%> (ø) |
|
.../features/Dashboard/components/MembershipPanel.tsx | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 56f7210...2a0fed9. Read the comment docs.
[sc-7907]
This pull request has been linked to Shortcut Story #7907: Fix address validation for RSK network in custom token form.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Don't close. @7alip have you looked more at this?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.