MyCrypto icon indicating copy to clipboard operation
MyCrypto copied to clipboard

Fix RSK EIP1191 checksum issues

Open 7alip opened this issue 3 years ago • 8 comments

Description

I created new PR according to requesting changes in #4139

Changes

  • Renamed isValidETHRecipientAddress with isValidRecipientAddress which now takes chainId parameter.
  • Removed unnecessary network state and updated schema validation.
  • Added network parameter to TO_FIELD_ERROR translation.
  • Reverted changes in providerHandler to find a better solution.

This changes are supposed to fix checksum errors in the following scenarios:

  • Send Asset through RSK and RSK Testnet networks and
  • In Settings add RSK and RSK Testnet addresses to Address Book

Issues

There are more scenarios where EIP1191 checksum validation needs to be fixed.

  • Interact with Contracts
  • Add Custom Token

We discussed for the better solution as to have support for it in Ethers.js.

7alip avatar Sep 30 '21 15:09 7alip

/ok-to-test

FrederikBolding avatar Oct 04 '21 09:10 FrederikBolding

Codecov Report

Merging #4151 (2a0fed9) into master (56f7210) will decrease coverage by 0.01%. The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4151      +/-   ##
==========================================
- Coverage   77.43%   77.42%   -0.02%     
==========================================
  Files         551      551              
  Lines       12016    12018       +2     
  Branches     3197     3197              
==========================================
  Hits         9305     9305              
- Misses       2678     2680       +2     
  Partials       33       33              
Impacted Files Coverage Δ
...ures/InteractWithContracts/components/Interact.tsx 69.00% <ø> (ø)
.../features/Settings/components/AddToAddressBook.tsx 15.15% <0.00%> (-0.98%) :arrow_down:
src/components/GeneralLookupField.tsx 89.01% <100.00%> (ø)
.../features/SendAssets/components/SendAssetsForm.tsx 77.17% <100.00%> (+0.09%) :arrow_up:
src/services/EthService/validators.ts 95.93% <100.00%> (+0.12%) :arrow_up:
src/features/Faucet/helpers.tsx 100.00% <0.00%> (ø)
.../features/Dashboard/components/MembershipPanel.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56f7210...2a0fed9. Read the comment docs.

codecov[bot] avatar Oct 04 '21 09:10 codecov[bot]

[sc-7907]

FrederikBolding avatar Oct 04 '21 09:10 FrederikBolding

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '21 10:12 stale[bot]

Don't close. @7alip have you looked more at this?

FrederikBolding avatar Dec 03 '21 11:12 FrederikBolding

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 02 '22 06:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 06 '22 19:04 stale[bot]