MvvmCross icon indicating copy to clipboard operation
MvvmCross copied to clipboard

Support for WinUI3.0 and Net 5.0

Open andres-gimenez opened this issue 4 years ago • 6 comments

🚀 Feature Requests

Will WinUI3.0 be deployed with Net5.0 on MvvmCross 7?

Contextualize the feature

Describe the feature

Platforms affected (mark all that apply)

  • [ ] :iphone: iOS
  • [ ] :robot: Android
  • [x] :checkered_flag: WPF
  • [x] :earth_americas: UWP
  • [ ] :apple: MacOS
  • [ ] :tv: tvOS
  • [ ] :monkey: Xamarin.Forms

andres-gimenez avatar Jun 28 '20 17:06 andres-gimenez

Not in the first version of MvvmCross 7. Unless you have something ready right now. We are open for contributions though!

Cheesebaron avatar Jun 29 '20 18:06 Cheesebaron

Not in the first version of MvvmCross 7. Unless you have something ready right now. We are open for contributions though!

I tested a build with net5.0. But I've come across trouble.

  • Now MSBuild.Sdk.Extras doesn't support Net5.0.
  • WPF and UWP are unified. But I don't know how.

Now it's not well known as Net5.0 will be but I want to know how the migration will be done. By platforms or all together.

If I can help. I'm delighted.

andres-gimenez avatar Jun 29 '20 19:06 andres-gimenez

+1 for support WinUI 3.0, it looks cool.

pinkysek avatar Jul 07 '20 11:07 pinkysek

I tried to convert my existing UWP app (using WinUI 2.5 + MvvmCross) to WinUI UWP 3. Things didn't go well.

My observations

  • Anything inherits Windows.UI.Xaml.Controls should be changed to Microsoft.UI.Xaml.Controls. Including MvxWindowsPage
  • MvxCommand and MvxAsyncCommand inherits System.Windows.Input.ICommand. However, WinUI3 controls expect XamlUICommand There must be either some converter to use it in XAML, or a new class implementation.
  • Same goes for INotifyCollectionChanged and INotifyPropertyChanged (Check known issues) . They have different namespaces in WinUI3 Preview.
  • UWP and Win32 worlds are quite different now in WinUI3. Unification still continues, but based on the current implementation and targeting options it is not possible to do it in MvvmCross with less effort.
  • Anything dialog related is not fully supported in WinUI3. For example ContentDialog because it binds to PopupRoot where it's not available in WinUI Visual Tree yet. MvvmCross's view presenter for UWP should be aware of this and adjust when this bug is fixed.

Basically it is not possible to do it until WinUI3 goes GA. There are still ongoing discussions in WinUI community about basically everything. Since there are a lot of stuff that needs to be implemented, team is changing/adjusting the previous code according to the new APIs.

bkaankose avatar Jan 18 '21 01:01 bkaankose

Any updates on supporting WinUI 3? Is this up for grabs? Is someone already tackling it?

dahovey avatar Nov 08 '21 13:11 dahovey

@bkaankose Looks like since your last comment, Windows App SDK (or Project Reunion) for 0.8.5 is GA per here.

I believe I addressed your concerns in PR #4316

dahovey avatar Nov 08 '21 23:11 dahovey