foundryvtt-shadowdark icon indicating copy to clipboard operation
foundryvtt-shadowdark copied to clipboard

[BUG] Unnecessary "items not found" warning for "+2 Stats Points" from ShadowDarklings

Open johncarney opened this issue 5 months ago • 1 comments

When importing a character that rolled the "+2 points to distribute to any stats" talent from ShadowDarklings, the importer shows a "items not found" and presents a "partially import" button. This is even though the character has two corresponding "+1 to [ability]" talents in the JSON. This could lead to potential confusion.

It's debatable whether this is a problem in ShadowDarklings or in the Shadowdark Foundry game system, but I would argue that ShadowDarklings is properly representing what was rolled and the importer should either simply ignore "+2 Stats Points" items in the JSON, or (ideally) check that there are the correct number of corresponding "+1 to [ability]" items before presenting a warning.

Example JSON

Snubrogg.json

Screenshots

Note that 14 was rolled for CHA.

partially-import snubrogg-abilities snubrogg-talents

johncarney avatar Sep 10 '24 19:09 johncarney