Enhancement: Add consumable property to basic items

[PrototypeESBU]

A generic "consumable" property that allows the item to be "Used" and then is removed from inventory when quantity equals 0. Rations would benefit from this representation, but also Potions could be moved to being a basic items. Things like iron spikes could work with this as well.

[metrzero]

I'm looking at implementing this feature and would like input on my approach.

1. Add isConsumable as a peer to isAmmunition for basic items
2. Add "Consumable" checkbox to Item Properties in item editing
3. Add a new "Items" category under Abilities on player actor sheets.
4. Add a single localization item for the word "Consumable"
5. Clicking the item on the Abilities tab behaves similarly to attacks. It should:
   • Present an item card in chat
   • Reduce quantity by 1
   • Optionally delete the item if it has reached 0 quantity

5e makes deleting the item at zero quantity optional, which I like. I'm not sure if that's worthwhile here, or where the best place to add the option might be without cluttering up the UI.

[Muttley]

Mostly sounds fine to me. I'm not sure about duplicating inventory item on the Abilities tab though.

What do you think @PrototypeESBU ?

[PrototypeESBU]

@metrzero Thanks for looking into this! Things I think are a great idea:

• Points 1-2 as a way of making consumable logic more generic applicable.
• The idea of a secondary attribute for deleting or not when 0 quantity is reached.
• Consumable usage posted to chat.

My main disagreement is adding items to the ability tab. The ability tab primarily represents things that aren't available in your inventory, like attack variations and character abilities. I don't feel like it makes sense to add items into the mix, as a consumable item should have a consume button (like potions) available on the inventory screen.

It would be nice to replace potions as separate sub-type with this approach, but I'll have to think through the ramifications of that a bit more.

[metrzero]

Message received on the Abilities tab change. I thought it was an odd fit, but it raises the question of where do you recommend I add the "Use" action? Today clicking on an item on the inventory tab expands it to description, which I think is essential to retain.

[Muttley]

Message received on the Abilities tab change. I thought it was an odd fit, but it raises the question of where do you recommend I add the "Use" action? Today clicking on an item on the inventory tab expands it to description, which I think is essential to retain.

Probably an icon button similar to the way potions are currently handled (consumable type specific).