foundryvtt-shadowdark icon indicating copy to clipboard operation
foundryvtt-shadowdark copied to clipboard

Refactor: Chat Card technical cleanup

Open bakbakbakbakbak opened this issue 2 years ago • 2 comments

  • RollMode management
    • Blinded rolls
    • Pass RollMode to Dice So Nice! so it can use the correct visibility
  • Template cleanup; I think we have unused templates right now
  • Tours update as it looks for elements in the chat cards

bakbakbakbakbak avatar Apr 25 '23 10:04 bakbakbakbakbak

Additional feature request here:

  • Tagging each of the roll types

This came up while I was trying to do various luck implementations. It was difficult to do automation around chat cards because they didn't have a "type". They had rolls, but not a specific type. We should add this to the flags field on the ChatMessage.

Documenting these cleanly should also help with the cleanup because we'll have an explicit list of templates.

gatesvp avatar Oct 16 '23 01:10 gatesvp

@gatesvp : I think that should be a different refactor issue, there is a plethora of different rolls. But yeah, it should be linked to the issue due to the RollMode.

bakbakbakbakbak avatar Oct 21 '23 09:10 bakbakbakbakbak