Muttley
BUG: Asterion in Lost Citadel of the Scarlet Minotaur does not act as a +1 weapon
In the Quickstart adventure that comes with the Foundry VTT Shadowdark system, the item Asterion is described as a +1 greatsword, but when used there is no item bonus applied to either the attack or damage rolls.
UPDATE: While testing out my workaround on Asterion I discovered it is also missing a Base Weapon type, which means that characters who have greatsword Weapon Mastery will not gain the benefits of that talent when using this item.
FURTHER UPDATE: Going through the rest of the adventure I found that the +1 spear, Vigilant, and the +1 great axe, Bloodlust are similarly affected:
- Vigilant is missing a Base Weapon type and has the wrong attack and damage bonuses.
- Bloodlust has the wrong crit multiplier and attack and damage bonuses.
Steps to reproduce
See the video at the bottom of this post for a demonstration.
- Create a new Shadowdark RPG world in Foundry.
- Launch the world and import the Lost Citadel of the Scarlet Minotaur quickstart adventure.
- Activate the Lost Citadel scene and scroll the map to highlight room 9 in the top right corner of the map (Sorcerous Pillars).
- Double-click on the book icon to bring up the room description.
- Create a player actor and drag the item labelled Asterion from the room description onto the actor's inventory, then equip Asterion.
- Switch to the actor's
Abilitiestab and make an attack withAsterion. - Note that in the attack roll dialog, the item bonus is 0 when it should be one.
- Note aslo that in the chat card there is no +1 added to either the attack or damage rolls (besides whatever ability or talent bonuses the character might have.)
- ADDITIONAL: Repeat the steps 5 to 8 above, but for a character with greatsword Weapon Mastery. You will see that the appropriate talent bonus of rthis is not applied.
Diagnosis
Looking at the item's details, under the Effects tab, we see that it has two effects: an attackBonus, which applies +1 to system.attackBonus, and a damageBonus that applies +1 to system.damageBonus. It seems that these effects are invalid, possibly carried over from an older version of the system? On the item Details tab you will also see that it does not have a Base Weapon type.
Workaround
The workaround is to adjust the item's effects. Open the item's details, and add the Weapon Attack Roll Bonus and Weapon Attack Damage Bonus effects, then remove the existing attackBonus and damageBonus effects. Also, set the Base Weapon type to Greatsword. Working through the other items (Vigilant, and Bloodlust), make similar adjustments.
These changes can be made either on the items in the room descriptions before dragging them to the actor's inventory, or on the items once they are in an actor's inventory.
Video
https://github.com/user-attachments/assets/16044ccd-6426-420d-addd-a114b3f28ea4
It looks like this bug is still present for Bloodlust in 3.4.0 - it does not apply the +1 to attack or damage.
Asterion is working, but Bloodlust is not. If I update Bloodlust to use the same Effects as Asterion, the bonuses are applied.
The root cause of this is a missing data object being passed to RollSD._roll() when options.handedness is undefined. (RollSD.mjs line 469).
The secondary causes of this are:
- The macro function of rolling an item doesn't set the handedness unless it is versatile.
- When the Roll Attack button on a weapons chat card is clicked, it doesn't define handedness.
PR being sent for 3.6 branch. Will check 4.0.0 branch to see if it has the same flaw.
Updated Bloodlust and Vigilant in the Compendium packs to use Weapon Attack Bonus and Weapon Damage Bonus. Bloodlust x4 critical appears to be working as expected. Weapon Master is being applied as expected on Abilities tab and from Chat button triggers. Weapon Master isn't working for Macro button triggered attacks... need to investigate.
I stand corrected. Weapon Master is working as expected with Macro button triggered attacks.