mutiny-web icon indicating copy to clipboard operation
mutiny-web copied to clipboard

Add a /redeem route

Open futurepaul opened this issue 1 year ago • 6 comments

We have three (THREE!) new ways to get money into mutiny in PRs currently:

https://github.com/MutinyWallet/mutiny-web/pull/885 https://github.com/MutinyWallet/mutiny-web/pull/891 https://github.com/MutinyWallet/mutiny-web/pull/837

All three work on the premise of you pasting in something, and then you see some sort of preview, and then you click a button and get the money. (Potentially gifting can work like this as well, although rn it has its own path / ux)

LnurlW is a bit different because it can, optionally, have an editable receive amount, afaik cashu and fedi oob will always be fixed amounts.

I plan on building the /redeem route to unify these, just wanted to make this a discussion issue of any thoughts / gotchas I might need to have in mind when trying to unify the UX here.

@oleonardolima @elnosh @tompro any thoughts / special considerations I should be aware of?

futurepaul avatar Feb 22 '24 22:02 futurepaul

not sure where/how it should be handled but wondering about cases where the amount of the cashu token pasted is very low. Should we show a warning or something instead of a redeem button if the amount is too low?

elnosh avatar Feb 23 '24 01:02 elnosh

[...] afaik cashu and fedi oob will always be fixed amounts.

yes, at least for fedimint the oob's have fixed amounts

[...] I plan on building the /redeem route to unify these, just wanted to make this a discussion issue of any thoughts / gotchas I might need to have in mind when trying to unify the UX here.

I don't have any specific thoughts about it, and I agree that unifying it would be better.

The only thing is that currently, OOB would only work with copy/paste and not through QR, could that lead to bad UX somehow ? 🤔

oleonardolima avatar Feb 23 '24 12:02 oleonardolima

@elnosh what would too low mean, it's all burned to fees?

benthecarman avatar Feb 23 '24 12:02 benthecarman

maybe something below 5 sats. That could end up going most of it in fees.

elnosh avatar Feb 23 '24 12:02 elnosh

I just noticed that current LNUrlW implementation does not give access to the invoice that is processed. Showing a QR (that is never used) does not make much sense during processing. It will need access to the tx to show the exact received amt in the success screen later though.

tompro avatar Feb 24 '24 22:02 tompro

not sure where/how it should be handled but wondering about cases where the amount of the cashu token pasted is very low. Should we show a warning or something instead of a redeem button if the amount is too low?

You can just offer to trust the origin mint and do a swap instead of melting the cashu to LN. Then no fees.

EthnTuttle avatar Feb 25 '24 02:02 EthnTuttle