mutiny-node icon indicating copy to clipboard operation
mutiny-node copied to clipboard

Make NodeManager optional

Open benthecarman opened this issue 10 months ago • 6 comments

Was able to fix #1071 while i was at it

This puts the node manager in a RwLock that is by default off, only until create_node_manager is called will we have a lightning node and on-chain wallet. Otherwise it will use fedimint when there is no nodemanager or throw an error if neither are configured.

benthecarman avatar Apr 16 '24 01:04 benthecarman

This is getting close, want to write tests for everything but in my manual testing things seem to be working well

benthecarman avatar Apr 17 '24 04:04 benthecarman

~note to self: need to make sure bringing back a node manager doesn't create a new node and instead brings back the old nodes~

benthecarman avatar Apr 17 '24 05:04 benthecarman

needs rebase

TonyGiorgio avatar Jun 06 '24 22:06 TonyGiorgio

Errors when receiving on chain when only a federation is added

Screenshot 2024-06-06 at 8 01 02 PM

TonyGiorgio avatar Jun 07 '24 01:06 TonyGiorgio

Went through full testing guide, everything is working as of now. Going to add a few more things to it that will now apply with this

benthecarman avatar Jun 13 '24 00:06 benthecarman

discussed in meeting: don't default remove empty node managers

benthecarman avatar Jun 17 '24 18:06 benthecarman