Markus Lobedann

Results 33 comments of Markus Lobedann

IMHO this should still be merged

IMHO this should still be merged

> > In ERPNext some calls to it can be found where refresh_fields() is implicitely called afterwards. I guess to circumvent this problem. > > @Mutantpenguin could you also send...

What can I do to get this accepted? If it's a unittest, please point me to an existing one I can adjust/copy. I am thinking about adding another custom field...

> > Setting of properties without a setter (in case of virtual fields) just doesn't work and makes no sense anyway. > > Could you elaborate on what's the issue...

The removal shouldn't be backported to 14 and 15 IMHO, so it would need to be included in the migration guide for 16.

Any chance to get this merged?

Please see my remarks in https://github.com/frappe/frappe/issues/25178 why I think that `save_file` should be deleted. I already created a PR to do so in `erpnext` here https://github.com/frappe/erpnext/pull/41708. Regarding the other apps...